[virt-tools-list] [virt-manager PATCH v2] disable virtio disk with device type 'LUN'
Cole Robinson
crobinso at redhat.com
Tue Jan 21 13:49:57 UTC 2014
On 01/20/2014 08:24 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>
> We should not encourage user use device type 'LUN'
> if they selected virtio bus.
> This patch will prevent user from doing this.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
> v2: better solution than v1, remove virtio from lun_buses list
>
> virtManager/addhardware.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
> index d7ee161..05a23aa 100644
> --- a/virtManager/addhardware.py
> +++ b/virtManager/addhardware.py
> @@ -575,7 +575,7 @@ class vmmAddHardware(vmmGObjectUI):
> "usb", "virtio", "virtio-scsi", "xen"]
> floppy_buses = ["fdc"]
> cdrom_buses = ["ide", "scsi"]
> - lun_buses = ["virtio", "virtio-scsi"]
> + lun_buses = ["virtio-scsi"]
>
> if bus in disk_buses:
> model.append([virtinst.VirtualDisk.DEVICE_DISK,
>
Thanks, pushed now.
- Cole
More information about the virt-tools-list
mailing list