[virt-tools-list] [PATCH] Fix default_uri xen check

Cole Robinson crobinso at redhat.com
Sat Jan 25 16:56:11 UTC 2014


On 01/24/2014 03:35 PM, Charles Arnold wrote:
> The xend toolstack is deprecated upstream.  While support needs continue
> for this legacy toolstack, the newer libxl toolstack does not need xend
> to work.  Additionally, libvirt now has drivers for supporting the libxl
> toolstack.
> 
> This patch changes the check from /var/lib/xend to /var/lib/xen
> which is a common path in both toolstacks.  Neither the old path nor the
> new one actually proves that xend is currently running.  It just validates
> that xen has been installed on the machine.
> 
> Signed-off-by: Charles Arnold <carnold at suse.com>
> 
> diff --git a/virtManager/uihelpers.py b/virtManager/uihelpers.py
> index a50747d..b98663b 100644
> --- a/virtManager/uihelpers.py
> +++ b/virtManager/uihelpers.py
> @@ -1411,7 +1411,7 @@ def set_grid_row_visible(child, visible):
>  
>  
>  def default_uri(always_system=False):
> -    if os.path.exists('/var/lib/xend'):
> +    if os.path.exists('/var/lib/xen'):
>          if (os.path.exists('/dev/xen/evtchn') or
>              os.path.exists("/proc/xen")):
>              return 'xen:///'
> 

ACK, pushed now.

Thanks,
Cole




More information about the virt-tools-list mailing list