[virt-tools-list] [virt-manager PATCH 0/2] add support for virt-install option "--cpu host-model-basic"
Cole Robinson
crobinso at redhat.com
Mon Jan 27 15:10:04 UTC 2014
On 01/27/2014 02:48 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>
>
> Chen Hanxiao (2):
> virt-install: add support for option "--cpu host-model-basic"
> man: update virt-intall man page for option "--cpu host-model-basic"
>
> man/virt-install.pod | 5 +++++
> virtinst/cli.py | 3 +++
> 2 files changed, 8 insertions(+)
>
Idea and code look fine, but I don't like the name 'host-model-basic'. How
about 'host-model-only' or 'host-model-name' ?
Also, please squash the two patches together, for small option additions we
should just commit tests, docs, and code all together in one patch.
Thanks,
Cole
More information about the virt-tools-list
mailing list