[virt-tools-list] [PATCH virt-manager] tests: fix tests with latest libvirt from git

Cole Robinson crobinso at redhat.com
Thu Jan 30 16:07:51 UTC 2014


On 01/30/2014 05:31 AM, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  tests/cli-test-xml/compare/virtxml-add-disk-basic.xml          | 8 ++++----
>  tests/cli-test-xml/compare/virtxml-add-disk-create-storage.xml | 8 ++++----
>  tests/cli-test-xml/compare/virtxml-add-disk-notarget.xml       | 8 ++++----
>  tests/cli-test-xml/compare/virtxml-add-host-device.xml         | 8 ++++----
>  tests/cli-test-xml/compare/virtxml-add-sound.xml               | 8 ++++----
>  tests/cli-test-xml/compare/virtxml-edit-clear-clock.xml        | 6 +++---
>  tests/cli-test-xml/compare/virtxml-edit-clear-cpu.xml          | 6 +++---
>  tests/cli-test-xml/compare/virtxml-edit-simple-metadata.xml    | 6 +++---
>  tests/cli-test-xml/compare/virtxml-edit-simple-security.xml    | 6 +++---
>  tests/cli-test-xml/compare/virtxml-remove-disk-index.xml       | 8 ++++----
>  10 files changed, 36 insertions(+), 36 deletions(-)
> 

Hmm, I guess that's an unfortunate side effect of virt-xml tests pulling XML
from libvirt, we will likely hit this a lot.

This change will break running tests against older libvirt, so I pushed your
patch, and added some more infrastructure in clitest.py to do the right thing.

(also, in case you didn't see it, there's a variable at the top of clitest.py
named REGENERATE_OUTPUT, which you can set to True to refresh data
automatically. updating diffs by hand would not be fun)

- Cole




More information about the virt-tools-list mailing list