[virt-tools-list] [PATCH 1/2] Remove obsolete nsis installer support

Christophe Fergeau cfergeau at redhat.com
Tue Jun 10 09:45:52 UTC 2014


Hey,

ACK, one minor nit below,

On Mon, Jun 09, 2014 at 12:34:38PM +0100, Daniel P. Berrange wrote:
> Currently supported virt-viewer Windows builds are using the MSI
> installer approach. Remove the now-unused & obsolete support for
> NSIS installers. Since there's no upgrade path between NSIS and
> MSI installers, it will merely cause confusion to have both
> continue to be supported.
> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> @@ -47,8 +33,7 @@ msi: virt-viewer-$(WIXL_ARCH)-$(VERSION).msi
>  
>  CLEANFILES +=					\
>  	deps.txt				\
> -	virt-viewer-$(VERSION).exe		\
> -	virt-viewer-$(WIXL_ARCH)-$(VERSION).msi	\
> +	virt-viewer-$(WIXL_ARCH)-$(VERSION).msi \
>  	$(NULL)

Nit: the 'virt-viewer-$(WIXL_ARCH)-$(VERSION).msi' change is unneeded
here (it changes a trailing tab to a trailing space).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140610/b6719352/attachment.sig>


More information about the virt-tools-list mailing list