[virt-tools-list] [PATCH virt-viewer] msi: move up micro version in x.x.build productversion

[Daniel P. Berrange]

On Mon, Jun 09, 2014 at 08:00:09AM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > On Fri, Jun 06, 2014 at 06:26:27PM +0200, Marc-André Lureau wrote:
> > > This allows 12 bits to form a buildid, ex in RHEVM builds:
> > > --with-buildid=$(release << 4 + zrelease)
> > > 
> > > https://bugzilla.redhat.com/show_bug.cgi?id=1105650
> > > ---
> > >  configure.ac | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index f966688..067c918 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -225,7 +225,9 @@ buildid=`echo $with_buildid | cut -d. -f1`
> > >  if test "x$buildid" = x; then
> > >     buildid=0
> > >  fi
> > > -build=`expr $micro \* 256 + $buildid`
> > > +# In RHEV builds
> > > +# build = $micro << 12 + (%release[0] << 4 + %release[1])
> > > +build=`expr $micro \* 4096 + $buildid`
> > >  WINDOWS_PRODUCTVERSION="$major.$minor.$build"
> > >  AC_SUBST([WINDOWS_PRODUCTVERSION])
> > 
> > Yep, this looks like a reasonable thing to do in distros which are using
> > our current virt-viewer releases based on a 3-component version numbering
> > scheme. Perhaps apply this to GIT now, so we have it in historical
> > record, and then I'll apply my patches to switch to 2-component version
> > numbers ontop of it
> 
> that's my preference too, thanks for the change!

So ACK to this patch of yours

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|