[virt-tools-list] [PATCH virt-viewer] util: fix glib_check_version() condition

[Marc-André Lureau]

Regardless there is another iteration of  --debug handling, I am pushing
this fix as trivial.


On Thu, Jun 12, 2014 at 8:21 AM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> On Wed, Jun 11, 2014 at 11:54:31AM -0400, Marc-André Lureau wrote:
> >
> >
> > ----- Original Message -----
> > > On Wed, Jun 11, 2014 at 05:21:59PM +0200, Marc-André Lureau wrote:
> > > > glib_check_version() returns NULL if version is higher or equal.
> > > > ---
> > > >  src/virt-viewer-util.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/src/virt-viewer-util.c b/src/virt-viewer-util.c
> > > > index c81c09a..6fdaa07 100644
> > > > --- a/src/virt-viewer-util.c
> > > > +++ b/src/virt-viewer-util.c
> > > > @@ -283,7 +283,7 @@ static void log_handler(const gchar *log_domain,
> > > >                          const gchar *message,
> > > >                          gpointer unused_data)
> > > >  {
> > > > -    if (!glib_check_version(2, 32, 0))
> > > > +    if (glib_check_version(2, 32, 0) != NULL)
> > > >          if (log_level >= G_LOG_LEVEL_DEBUG && !doDebug)
> > > >              return;
> > >
> > >
> > > Or maybe this?
> >
> > Well, it's not like we are using a different API, so I prefer the
> dynamic version.
>
> Sorry, I did not understand what you mean in the first part of your
> sentence :(
>
> Christophe
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>



-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140612/b5e8b733/attachment.htm>