[virt-tools-list] [virt-manager PATCH] diskbackend: make surepath existed before checking vol info

[Chen Hanxiao]

On 06/13/2014 10:50 PM, Giuseppe Scrivano wrote:
> "chenhanxiao at cn.fujitsu.com" <chenhanxiao at cn.fujitsu.com> writes:
>
>>> -----Original Message-----
>>> From: Giuseppe Scrivano [mailto:gscrivan at redhat.com]
>>> Sent: Friday, June 13, 2014 6:16 PM
>>> To: Chen, Hanxiao/陈 晗霄
>>> Cc: virt-tools-list at redhat.com
>>> Subject: Re: [virt-tools-list] [virt-manager PATCH] diskbackend: make sure path
>>> existed before checking vol info
>>>
>>> "chenhanxiao at cn.fujitsu.com" <chenhanxiao at cn.fujitsu.com> writes:
>>>
>>>>> I have tried several times by using a similar command line as in the bug
>>>>> report but I wasn't able to reproduce the problem here (both
>>>>> virt-install-1.0.1-3.fc20.noarch and upstream version), what arguments
>>>>> did you feed to virt-install to get this failure?
>>>>>
>>>> a) mkdir -p /home/rjones/d/libguestfs/builder/website/
>>>>
>>>> b) ./virt-install  --connect qemu:///system  --virt-type kvm  --name demo
>>> --memory 500   --cdrom /home/ISO/Fedora-20-x86_64-DVD.iso  --os-variant
>>> fedora20 --disk /home/rjones/d/libguestfs/builder/website/fedora-20,size=6
>>>> c) run and run again.
>>> thanks, now I can reproduce it here as well.
>>>
>>> The problem seems to be in libvirt that is not reporting the right error
>>> code, VIR_ERR_NO_STORAGE_VOL seems to be the appropriate error here and
>>> that is handled by virt-install, instead I get VIR_ERR_SYSTEM_ERROR.
>>>
>> Cool!
>> I did not have a remote connection environment.
>> If you have, pls do some tests.
>
> I've sent a patch for libvirt here:
>
> https://www.redhat.com/archives/libvir-list/2014-June/msg00655.html
>
> This solves the problem for me.  Treating VIR_ERR_SYSTEM_ERROR as
> VIR_ERR_NO_STORAGE_VOL doesn't seem like the correct thing to do in
> virt-install.
>
Looks reasonable.
I'll test it with patched libvirt on Monday.

Thanks,
- Chen