[virt-tools-list] [virt-manager PATCH] fix some missed binary prefixes for units

Chen Hanxiao chenhanxiao at cn.fujitsu.com
Mon Jun 16 07:38:39 UTC 2014


Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
---
 ui/host.ui             | 4 ++--
 virtconv/ovf.py        | 2 +-
 virtinst/cli.py        | 2 +-
 virtinst/xmlbuilder.py | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ui/host.ui b/ui/host.ui
index ee585a6..e1e2088 100644
--- a/ui/host.ui
+++ b/ui/host.ui
@@ -479,7 +479,7 @@
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="xalign">1</property>
-                                    <property name="label">1.59 GB of 2.2 GB</property>
+                                    <property name="label">1.59 GiB of 2.2 GiB</property>
                                   </object>
                                   <packing>
                                     <property name="expand">False</property>
@@ -1397,7 +1397,7 @@
                                         <property name="visible">True</property>
                                         <property name="can_focus">False</property>
                                         <property name="xalign">0</property>
-                                        <property name="label"><span size="large">1234 GB Free</span> / <i>6000 GB In Use</i></property>
+                                        <property name="label"><span size="large">1234 GiB Free</span> / <i>6000 GiB In Use</i></property>
                                         <property name="use_markup">True</property>
                                       </object>
                                       <packing>
diff --git a/virtconv/ovf.py b/virtconv/ovf.py
index 9521a1c..90fcf16 100644
--- a/virtconv/ovf.py
+++ b/virtconv/ovf.py
@@ -139,7 +139,7 @@ def _convert_alloc_val(ignore, val):
         return int(round(val / 1024.0))
 
     elif val < 32:
-        # Assume GB
+        # Assume GiB
         return int(val * 1024)
 
     return int(val)
diff --git a/virtinst/cli.py b/virtinst/cli.py
index 921feea..771045c 100644
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -820,7 +820,7 @@ def add_disk_option(stog, editexample=False):
         editmsg += "\n--disk cache=  (unset cache)"
     stog.add_argument("--disk", action="append",
         help=_("Specify storage with various options. Ex.\n"
-               "--disk size=10 (new 10GB image in default location)\n"
+               "--disk size=10 (new 10GiB image in default location)\n"
                "--disk path=/my/existing/disk,cache=none\n"
                "--disk device=cdrom,bus=scsi\n"
                "--disk=?") + editmsg)
diff --git a/virtinst/xmlbuilder.py b/virtinst/xmlbuilder.py
index 61c0b8d..1e09c4f 100644
--- a/virtinst/xmlbuilder.py
+++ b/virtinst/xmlbuilder.py
@@ -352,8 +352,8 @@ class XMLProperty(property):
             if xpath isn't specified.
         @param set_converter: optional function for converting the property
             value from the virtinst API to the guest XML. For example,
-            the Guest.memory API was once in MB, but the libvirt domain
-            memory API is in KB. So, if xpath is specified, on a 'get'
+            the Guest.memory API was once in MiB, but the libvirt domain
+            memory API is in KiB. So, if xpath is specified, on a 'get'
             operation we convert the XML value with int(val) / 1024.
         @param validate_cb: Called once when value is set, should
             raise a RuntimeError if the value is not proper.
-- 
1.9.0




More information about the virt-tools-list mailing list