[virt-tools-list] [PATCH virt-viewer] rhbz#1111514: Fix un-shrinkable displays on windows guests

Jonathon Jongsma jjongsma at redhat.com
Mon Jun 23 15:17:36 UTC 2014



----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Jonathon Jongsma" <jjongsma at redhat.com>
> Cc: virt-tools-list at redhat.com
> Sent: Monday, June 23, 2014 10:13:02 AM
> Subject: Re: [virt-tools-list] [PATCH virt-viewer] rhbz#1111514: Fix un-shrinkable displays on windows guests
> 
> > 
> > The thing that triggers us to show this status message is the 'ready' state
> > of the SpiceDisplay widget from spice-gtk. So if we wanted to change that
> > behavior, it should probably be done there. Or we could theoretically
> > decide that virt-viewer should not change to the 'status' notebook page
> > when a display becomes unready, but that doesn't seem like a good idea to
> > me. Perhaps we could switch to the status notebook in a timeout handler
> > (e.g. 100ms or so).  This way we'd avoid the case where it switches back
> > and forth immediately, but would still show the status message if the
> > widget didn't become ready before a certain time...
> 
> I think having a timeout like you describe would be better as this would
> hide this 'Waiting for display...' message, though there is no timeout
> that will work in all situation (slow remote connections), so I assume
> we would also need the patch that is being discussed, right ?
> 
> Christophe
> 


Yes, I think we would still need this patch, since we couldn't guarantee that the timeout is long enough to avoid showing the status on resizes.

Jonathon




More information about the virt-tools-list mailing list