[virt-tools-list] [virt-manager PATCH v2 2/2] engine: addmethods for showing config window

[chenhanxiao at cn.fujitsu.com]

> -----Original Message-----
> From: Giuseppe Scrivano [mailto:gscrivan at redhat.com]
> Sent: Tuesday, June 24, 2014 11:14 PM
> To: Chen Hanxiao
> Cc: Chen, Hanxiao/陈 晗霄; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH v2 2/2] engine: addmethods
> for showing config window
> 
> Chen Hanxiao <chen_han_xiao at 126.com> writes:
> 
> > On 06/24/2014 07:56 PM, Giuseppe Scrivano wrote:
> >> Chen Hanxiao <chenhanxiao at cn.fujitsu.com> writes:
> >>
> >>> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >>> ---
> >>> v2: add right-click menu support
> >>>
> >>>   virtManager/config.py | 4 ++++
> >>>   virtManager/engine.py | 8 +++++++-
> >>>   2 files changed, 11 insertions(+), 1 deletion(-)
> >> I thought the idea was to have a new item in the right click menu,
> >> something like "Show details", that opens the detail window while the
> >> "Open" item is left unchanged and displays the console.  Do you like
> >> this idea?
> >>
> >> Anyway, that is just my opinion, probably you would like to hear more
> >> opinions before change anything :-)
> >>
> > Good idea.
> > But this could not solve double click case Richard worried about.
> >
> > How about adding a new item in right click menu as well as adding
> > a configuareble 'Open' button?
> 
> I like the idea of having a configurable "Open" button as well as the
> default action when double clicking on a VM.
> 

It sound like the v1 patch sets
with a plus one: add a new item in right click menu:

a) add a new signal action-show-details for "Open" button, which is configurable.
b) add a new item in right click menu
c) double click will still open VM console

Thanks,

- Chen