[virt-tools-list] [PATCH virt-manager 5/5] virtManager: show QoS information for a network

[Giuseppe Scrivano]

Cole Robinson <crobinso at redhat.com> writes:

> On 06/25/2014 07:05 AM, Giuseppe Scrivano wrote:
>> Add UI elements to display QoS settings in the network details.
>> 
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1089117
>> 
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>  ui/host.ui             | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  virtManager/host.py    | 19 +++++++++++
>>  virtManager/network.py |  2 ++
>>  3 files changed, 106 insertions(+)
>
> Actually I think we can save some work and make this more generally useful by
> not exposing this bit in the createnet wizard, but making it unconditionally
> visible and editable in the network details page. Keeps the createnet wizard
> focused on the essential bits, and allows tweaking bandwidth for existing
> networks. Thoughts?

I've also thought about the possibility of editing these settings, but
then I've followed the same pattern used for other settings and used the
details window only to display QoS if used.  I can change it and use
pieces from 3/5 into this patch.

Regards,
Giuseppe