[virt-tools-list] [PATCH virt-viewer 2/3] spice: implement can-auto-resize

Daniel P. Berrange berrange at redhat.com
Wed Mar 12 17:27:24 UTC 2014


On Wed, Mar 12, 2014 at 01:23:53PM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > On Wed, Mar 12, 2014 at 01:05:15PM -0400, Marc-André Lureau wrote:
> > IMHO a better fix would be to simply remove this menu option completely
> > as it serves little purpose and we can't even inform the user whether
> > change it will have any effect at all.
> 
> Well, at least we could make sure we don't resize the guest ourself.
> 
> I don't know anybody who requested this feature, and I am probably the one
> to blame if it's there.
> 
> I guess I imagined at the time it was added that it could be annoying for
> some users to have the guest resized: If they have a preferred resolution,
> with their icons and windows placed on the desktop appropriately and it gets
> changed just by a mere window resize. But since this setting isn't saved
> automatically, and can't be set via the initial .vv file, I guess it shouldn't
> be a problem if we remove the menu item too. At least, I'd be fine with that.

I thought we had it originally because auto-resize was somewhat unreliable
to start off with. It has matured pretty well since SPICE first got that
feature though, so we ought to be able to rely on it these days IMHO.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the virt-tools-list mailing list