[virt-tools-list] [PATCH virt-viewer 2/2] RFC: resize: simplify and isolate fullscreen aspect logic

[Daniel P. Berrange]

On Wed, Mar 12, 2014 at 01:30:45PM -0400, Marc-André Lureau wrote:
> 
> 
> > What about the fix I suggested elsewhere in the thread
> > 
> > diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> > index 05d5fe7..c2551d4 100644
> > --- a/src/virt-viewer-window.c
> > +++ b/src/virt-viewer-window.c
> > @@ -446,11 +446,11 @@ virt_viewer_window_resize(VirtViewerWindow *self,
> > gboolean keep_win_size)
> >          /* Doesn't fit native res, so go as large as possible
> >             maintaining aspect ratio */
> >          if (screenAspect > desktopAspect) {
> > -            width = desktopHeight * desktopAspect;
> > -            height = desktopHeight;
> > +            width = (fullscreen.height - 128) * desktopAspect;
> > +            height = (fullscreen.height - 128);
> >          } else {
> > -            width = desktopWidth;
> > -            height = desktopWidth / desktopAspect;
> > +            width = (fullscreen.width - 128);
> > +            height = (fullscreen.width - 128) / desktopAspect;
> >          }
> >      } else {
> >          width = desktopWidth;
> > 
> > 
> > if that's not sufficient, then perhaps we should just remove
> > the '-128' fudge factor, so we're not trying to second guess
> > panel size.
> 
> That should solve the most important issue, being this code triggered when just maximizing the window: ack from me.

Ok, I just sent a formal patch for that.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|