[virt-tools-list] [PATCH v2 virt-manager 0/2] show domain state reason

Cole Robinson crobinso at redhat.com
Thu Mar 20 00:25:29 UTC 2014


On 03/19/2014 08:03 AM, Giuseppe Scrivano wrote:
> Giuseppe Scrivano (2):
>   virtManager: read the reason for the domain state
>   virtManager: show the state reason in the VM overview
> 
>  virtManager/details.py |  3 ++-
>  virtManager/domain.py  | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  virtinst/support.py    |  1 +
>  3 files changed, 63 insertions(+), 1 deletion(-)
> 

One suggestion: if the reason isn't in our string table, or the connection
doesn't support the API, I'd rather print 'Shutoff' than 'Shutoff (Unknown)'
since Unknown is a bit ambiguous and potentially scary.

ACK otherwise, feel free to just push with that change if you agree.

Thanks,
Cole




More information about the virt-tools-list mailing list