[virt-tools-list] [virt-manager PATCH] details: do not show MAC address if not set

[Giuseppe Scrivano]

"Chen, Hanxiao" <chenhanxiao at cn.fujitsu.com> writes:

>> -----Original Message-----
>> From: virt-tools-list-bounces at redhat.com
>> [mailto:virt-tools-list-bounces at redhat.com] On Behalf Of Giuseppe Scrivano
>> Sent: Friday, November 14, 2014 4:51 PM
>> To: virt-tools-list at redhat.com
>> Subject: [virt-tools-list] [virt-manager PATCH] details: do not show MAC address
>> if not set
>> 
>> Fixes this exception:
>> Traceback (most recent call last):
>>   File "virt-manager/virtManager/create.py", line 1780, in finish
>>     self.customize(guest)
>>   File "virt-manager/virtManager/create.py", line 1812, in customize
>>     self.config_window = vmmDetails(virtinst_guest, self.topwin)
>>   File "virt-manager/virtManager/details.py", line 560, in __init__
>>     self.populate_hw_list()
>>   File "virt-manager/virtManager/details.py", line 3165, in populate_hw_list
>>     self.repopulate_hw_list()
>>   File "virt-manager/virtManager/details.py", line 3220, in repopulate_hw_list
>>     update_hwlist(HW_LIST_TYPE_NIC, dev)
>>   File "virt-manager/virtManager/details.py", line 3195, in update_hwlist
>>     label = _label_for_device(dev)
>>   File "virt-manager/virtManager/details.py", line 188, in _label_for_device
>>     return "NIC %s" % dev.macaddr[-9:]
>> TypeError: 'NoneType' object has no attribute '__getitem__'
>> 
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1164123
>> 
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>
> ACK.

thanks, pushed now.

Regards,
Giuseppe