[virt-tools-list] [PATCH virt-viewer 6/9] Simplify virt_viewer_initial_connect()

Marc-André Lureau marcandre.lureau at gmail.com
Fri Nov 14 13:35:52 UTC 2014


On Fri, Nov 14, 2014 at 2:24 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> Well, I beg to disagree on the 'easy to read' part as I would not have
> split
> it if I had found it that easy to read ;)
>

I agree, the original code is not so easy to read, the rewritten version
however is.


> "fairly small" and "easy to read" are really secondary to "one change by
> patch", which I don't think the initial patch achieved.
>

It is a rewrite, really no steps involved when I did it, it's hard to come
up with steps which I think are artificial, but as I said, let's go with
your 3 patches then


-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20141114/a4de0c5d/attachment.htm>


More information about the virt-tools-list mailing list