[virt-tools-list] [virt-viewer] [PATCH] Listen to virNetwork's Lifecycle events

[Fabiano Fidêncio]

Daniel,

On Wed, Nov 19, 2014 at 1:36 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> On Wed, Nov 19, 2014 at 12:39:25PM +0100, Christophe Fergeau wrote:
>> Hey,
>>
>> On Wed, Nov 19, 2014 at 04:31:00AM +0100, Fabiano Fidêncio wrote:
>> > Apart from the usual virDomain's Lifecycle events, we have to listen to
>> > the virNetwork's Lifecycle events in order to get notifications about
>> > libvirt deamon being started/stopped/restarted, which is useful when
>> > connecting to guest through qemu+ssh://
>>
>> virNetwork lifecycle events are related to libvirt networks
>> started/stopped with virsh net-start/virsh net-destroyed. That you get
>> such events when libvirtd restarts seems to just be a side-effect.
>
> In fact I'm not even sure how this helps solve the quoted problem of
> detecting libvirtd restarts.
>
>  1. virt-viewer has a connection to libvirtd PID 123
>  2. virt-viewer listens for events from libvirtd PID 123
>  2. libvirtd PID 123 stops
>  3. libvirtd PID 456 starts
>  4. libvirtd PID 456 emits started events for virNetwork
>
> How exactly is virt-viewer supposed to be able to use the
> virNetwork events to detect libvirtd restarts ? They are
> being  emitted by a libvirtd daemon that virt-viewer is
> not even connected to.

You're right. It doesn't make sense.
I had a wrong idea about the purpose of the event. Unluckily, for a
reason that makes as much sense as my understanding of the event
(none!) it actually made the virt-viewer behaves as expected.

I have moved the bug in question to libvirt and resent the patches
that still make sense.

Best Regards,
-- 
Fabiano Fidêncio