[virt-tools-list] [PATCH virt-manager] console: switch to CONSOLE_PAGE_UNAVAILABLE while waiting for login

Giuseppe Scrivano gscrivan at redhat.com
Thu Nov 20 14:54:23 UTC 2014


Cole Robinson <crobinso at redhat.com> writes:

> On 11/20/2014 04:43 AM, Giuseppe Scrivano wrote:
>> It fixes a race condition if the ERROR_AUTH error if received while
>> still on the CONSOLE_PAGE_AUTHENTICATE and skipping the page_changed
>> event.
>>
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1165990
>>
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>   virtManager/console.py | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/virtManager/console.py b/virtManager/console.py
>> index 3080687..df90518 100644
>> --- a/virtManager/console.py
>> +++ b/virtManager/console.py
>> @@ -937,6 +937,7 @@ class vmmConsolePages(vmmGObjectUI):
>>           self.widget("console-gfx-scroll").queue_resize()
>>
>>       def auth_login(self, ignore):
>> +        self.widget("console-pages").set_current_page(CONSOLE_PAGE_UNAVAILABLE)
>>           self.set_credentials()
>>           self.activate_viewer_page()
>>
>>
>
> ACK

pushed.

Thanks,
Giuseppe




More information about the virt-tools-list mailing list