[virt-tools-list] [virt-manager RFC PATCH] spec: add a dependency on "gnome-icon-theme"

[Cole Robinson]

On 10/01/2014 05:49 AM, Giuseppe Scrivano wrote:
> virt-manager uses some icons included in the gnome-icon-theme package.
> Make it explicit and add a dependency.
> 
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1146612
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  virt-manager.spec.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/virt-manager.spec.in b/virt-manager.spec.in
> index 7a95cc3..dc089ec 100644
> --- a/virt-manager.spec.in
> +++ b/virt-manager.spec.in
> @@ -51,6 +51,7 @@ Requires: libosinfo >= 0.2.10
>  # For console widget
>  Requires: gtk-vnc2
>  Requires: spice-gtk3
> +Requires: gnome-icon-theme
>  
>  
>  BuildRequires: intltool
> 

The problem is that multiple different icon themes provide an input-tablet
icon for example. However it looks like some gtk apps like
system-config-printer do the same thing, so I'm okay with it. But for
completeness the best thing to do is ping one of the gtk maintainers to ask if
there's some standard operating procedure here, maybe gtk should have this dep.

- Cole