[virt-tools-list] [PATCH v2] Code related to vm_choose_dialog moved into separate files

Pavel Grunt pgrunt at redhat.com
Thu Oct 9 12:26:01 UTC 2014


Hi Christophe,

> 
> Hey,
> 
> I believe this can be squashed into the ovirt commit as this hasn't
> been
> committed yet? If this makes sense to you, I'll do the change myself
> before pushing.
> 
It makes sense.

> You also need to update po/POTFILES.in when you add new files with
> translations. cd po/; intltool-update -m; will tell you about the
> missing files. I've fixed that locally so no need to send another
> iteration of the patches.
> 
> Regarding the commit logs, I'd tend to use
> "Show VM chooser dialog when oVirt VM name is missing"
> and
> "Show VM chooser dialog when starting virt-viewer with no arg" (even
> though it's a bit long)
> When looking at the git short log (git log --oneline), it's more
> explicit what these commits are about this way.
> Do you mind if I change them?
> 
I don't mind, it sounds better.

> Thanks,
> 
> Christophe
> 

Thanks,
Pavel




More information about the virt-tools-list mailing list