[virt-tools-list] [PATCH] devicedisk: Fix conflict checking when connecting a floppy media

Cole Robinson crobinso at redhat.com
Mon Oct 27 21:51:48 UTC 2014


On 10/27/2014 04:43 PM, Lin Ma wrote:
> When connecting a floppy media, It always reports media conflict no matter it
> is in use or not, This patch fixes it.
> 
> Signed-off-by: Lin Ma
> ---
> virtinst/devicedisk.py | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
> index 1d764d9..00b8000 100644
> --- a/virtinst/devicedisk.py
> +++ b/virtinst/devicedisk.py
> @@ -422,6 +422,9 @@ class VirtualDisk(VirtualDevice):
> if disk.path != path:
> continue
> 
> + if disk.type == "block" and disk.device == "floppy":
> + continue
> +
> if shareable and disk.shareable:
> continue
> if read_only and disk.read_only:
> -- 
> 1.8.4
> 
> 

Yeah not sure what happened with this submission, sent as html mail maybe?

Sorry for the review delay, I'll respond to your initial patch now.

- Cole




More information about the virt-tools-list mailing list