[virt-tools-list] [virt-manager PATCH 0/2] fix a shortkey gtk asserstion warning in fsdetails when combo is invisible

[Chen, Hanxiao]

> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Tuesday, October 28, 2014 6:03 AM
> To: Giuseppe Scrivano; Chen, Hanxiao/陈 晗霄
> Cc: virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH 0/2] fix a shortkey gtk
> asserstion warning in fsdetails when combo is invisible
> 
> On 10/20/2014 06:19 AM, Giuseppe Scrivano wrote:
> > Chen Hanxiao <chenhanxiao at cn.fujitsu.com> writes:
> >
> >> How to reproduce:
> >> a) open a lxc-container vm details window
> >> b) choose a filesystem tag
> >> c) Alt + o
> >>
> >> Chen Hanxiao (2):
> >>   ui: change fs-type label ID from "label18" to "fs-type-title"
> >>   fsdetails: fix a shortkey issue when combo is invisible
> >>
> >>  ui/fsdetails.ui          |  2 +-
> >>  virtManager/fsdetails.py | 18 ++++++++++++++++++
> >>  2 files changed, 19 insertions(+), 1 deletion(-)
> >
> > wouldn't be better to leave it so we can more easily test for duplicate
> > shortcuts?  Anyway, I've not a strong opinion, so better wait for Cole.
> >
> 
> I don't like how this essentially duplicates the label content between the
> python code and gtkbuilder file. Not really worth adding code just to handle
> this minor issue IMO, so NACK
> 

OK, let's drop this one.

Thanks,
- Chen