[virt-tools-list] [PATCH] devicedisk: Fix conflict checking when connecting a floppy media

[Lin Ma]

When attacing an image to a virtual floppy drive, says clicking 'Connect' button,
Picking up an image, clicking 'OK' button, It always warns user that the image is in used.
The patch fixes this issue, But I just found the patch code doesn't make sense,
So I will resend it once I fix it in a better way.

Thanks,
Lin




>>> Cole Robinson <crobinso at redhat.com> 10/27/14 3:53 PM >>>
On 10/16/2014 08:40 AM, Lin Ma wrote:
> When connecting a floppy media, It always reports media conflict no matter it
> is in use or not, This patch fixes it.
> 
> Signed-off-by: Lin Ma 
> ---
>  virtinst/devicedisk.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
> index 1d764d9..00b8000 100644
> --- a/virtinst/devicedisk.py
> +++ b/virtinst/devicedisk.py
> @@ -422,6 +422,9 @@ class VirtualDisk(VirtualDevice):
>                  if disk.path != path:
>                      continue
>  
> +                if disk.type == "block" and disk.device == "floppy":
> +                    continue
> +
>                  if shareable and disk.shareable:
>                      continue
>                  if read_only and disk.read_only:
> 

I'm unclear what this is fixing... can you elaborate on what exactly this is
fixing? What path are you passing to virt-manager or virt-install and what
error is it giving?

Thanks,
Cole



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20141029/61c41ab0/attachment.htm>