[virt-tools-list] [PATCH V5 1/2] Add comparison function for NodeDevice

[Cole Robinson]

On 09/16/2014 05:42 AM, Lin Ma wrote:
> PCIDevice and USBDevice include respective comparison logic.
> 
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  virtManager/details.py | 47 ++---------------------------------------
>  virtinst/nodedev.py    | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 59 insertions(+), 45 deletions(-)
> 

You fixed the initify bit, but you missed my suggestion about

- Renaming the function to compare_to_hostdev
- Making the function nonstatic, and instead make it def
compare_to_hostdev(self, hostdev)

Please fix those bits as well

Thanks,
Cole