[virt-tools-list] [virt-viewer: PATCH 2/3 v2] Let the user set the username in the SPICE auth dialog

[Jonathon Jongsma]

On Tue, 2014-09-23 at 20:41 +0200, Fabiano Fidêncio wrote:
> Currently virt-viewer doesn't allow the user to set his/her username
> in the SPICE authentication dialog.
> Now, auto fill the dialog with the current user name as username and
> leave to the user the possibility to change it, if necessary.
> ---
> v2: Fix typo in the shortlog/commit message
> ---
>  src/virt-viewer-session-spice.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c
> index dd96fdf..6b61ce8 100644
> --- a/src/virt-viewer-session-spice.c
> +++ b/src/virt-viewer-session-spice.c
> @@ -509,10 +509,11 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED
>                                    _("invalid password"));
>          self->priv->pass_try++;
>  
> +        user = g_strdup (g_get_user_name());
>          ret = virt_viewer_auth_collect_credentials(self->priv->main_window,
>                                                     "SPICE",
>                                                     NULL,
> -                                                   NULL, &password);
> +                                                   &user, &password);
>          if (!ret) {
>              g_signal_emit_by_name(session, "session-cancelled");
>          } else {


Hmm, I've never had the need to specify a username for Spice auth. When
is that needed? Even if it was needed, it doesn't appear that the 'user'
variable is actually used for anything in this patch. Am I missing
something?