[virt-tools-list] [PATCH virt-viewer 1/3] man: document usage of domain name as optional

[Fabiano Fidêncio]

On Tue, Apr 14, 2015 at 2:08 PM, Pavel Grunt <pgrunt at redhat.com> wrote:
> related: rhbz#1211573
> ---
>  man/virt-viewer.pod    | 6 +++++-
>  src/virt-viewer-main.c | 2 +-
>  2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/man/virt-viewer.pod b/man/virt-viewer.pod
> index e976c69..50f08a7 100644
> --- a/man/virt-viewer.pod
> +++ b/man/virt-viewer.pod
> @@ -5,7 +5,7 @@ virt-viewer - display the graphical console for a virtual machine
>
>  =head1 SYNOPSIS
>
> -B<virt-viewer> [OPTIONS] -- DOMAIN-NAME|ID|UUID
> +B<virt-viewer> [OPTIONS] [DOMAIN-NAME|ID|UUID]
>
>  =head1 DESCRIPTION
>
> @@ -157,6 +157,10 @@ To connect to the guest called 'demo' running under Xen
>
>     virt-viewer demo
>
> +To connect to a guest running under QEMU using gui

Hmm.
I'd prefer to have it explicit that using GUI you're going to choose a
guest, like:
To connect to a guest running under QEMU that will be chosen using GUI
(or something equivalent with a better English than mine :-))

> +
> +   virt-viewer --connect qemu:///system
> +
>  To connect to the guest with ID 7 running under QEMU
>
>     virt-viewer --connect qemu:///system 7
> diff --git a/src/virt-viewer-main.c b/src/virt-viewer-main.c
> index 75de7c6..8c1ca80 100644
> --- a/src/virt-viewer-main.c
> +++ b/src/virt-viewer-main.c
> @@ -104,7 +104,7 @@ int main(int argc, char **argv)
>      g_option_context_free(context);
>
>      if (args && (g_strv_length(args) != 1)) {
> -        g_printerr(_("\nUsage: %s [OPTIONS] DOMAIN-NAME|ID|UUID\n\n%s\n\n"), argv[0], help_msg);
> +        g_printerr(_("\nUsage: %s [OPTIONS] [DOMAIN-NAME|ID|UUID]\n\n%s\n\n"), argv[0], help_msg);
>          goto cleanup;
>      }
>
> --
> 2.3.5
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list



-- 
Fabiano Fidêncio