[virt-tools-list] [PATCH virt-viewer v2 0/7] RFC: Avoid opening extra displays in fullscreen mode

[Fabiano Fidêncio]

Hey!

On Wed, Apr 22, 2015 at 11:02 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
>>
>> Here's a second version of the patch. The first four patches are
>> pretty much
>> the same as the first patchset that I sent, but there are some
>> additional
>> patches to handle some issues that Pavel reported while testing.
>> Thanks, Pavel!
>>
>> Jonathon Jongsma (7):
>>   SessionSpice: keep a list of display channels
>>   SessionSpice: save initial fullscreen configuration
>>   SessionSpice: Keep track of auto conf state
>>   Fullscreen auto-conf: wait for server to be configured
>>   Configure display before adding it to the session
>>   Apply zoom setting to fullscreen auto-conf
>>   Cleanup: remove unused function
>>
>>  src/virt-viewer-app.c           |   5 ++
>>  src/virt-viewer-app.h           |   2 +-
>>  src/virt-viewer-session-spice.c | 194
>>  ++++++++++++++++++++++++++++++++++------
>>  3 files changed, 173 insertions(+), 28 deletions(-)
>>
>
> Hi Jonathon, it looks good, even the zoom in fullscreen mode is working much better.
>
> Ack from me.

NAK from me!
With your patches applied I can easily reproduce (using rhel6 as
guest) a disabled coming back when not in the fullscreen mode.

Steps to reproduce:
1) Start a VM with 3 displays enabled
2) Disable the 2nd display

You will see the second display coming back.

Here is the log (--debug --spice-debug) of the issue:
https://fidencio.fedorapeople.org/jjongsma_series.log

Best Regards,
-- 
Fabiano Fidêncio