[virt-tools-list] [virt-manager PATCH] hostdev: add an address element for USB host devs if necessary

[Giuseppe Scrivano]

Pavel Hrdina <phrdina at redhat.com> writes:

> This issue was fixed for few years but only in virt-manager,
> virt-install has the same bug.  If you have two USB devices with same
> vendor and product ID, you need to use also address element to create
> a valid XML to define that device into a guest.
>
> This patch moves the logic from vmmAddHardware into VirtualHostDevice in
> order to not duplicate that code for virt-manager and virt-install.
>
> Also update the tests files to properly check this functionality.  I've
> changed the USB device according the 'tests/testdriver.xml' and picked
> one of the USB HUBs, because they have the same vendor and product ID.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1230611
>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>

ACK, I am going to push it in a while.

Regards,
Giuseppe