[virt-tools-list] [PATCH 3/4] Port to GtkApplication API's

[Daniel P. Berrange]

On Wed, Dec 02, 2015 at 12:09:56PM +0100, Christophe Fergeau wrote:
> Hey,
> 
> On Fri, Nov 27, 2015 at 05:24:00PM -0200, Eduardo Lima (Etrunko) wrote:
> > Most of this patch consists in code being shuffled around to fit the
> > expected flow while using the new APIs. I tried my best to make this
> > patch the less intrusive as possible. Main changes are:
> > 
> > - VirtViewerApp is now a subclass of GtkApplication
> > 
> >   Also, some mainloop calls were replaced, as follows:
> >    * gtk_main() -> g_application_run()
> >    * gtk_quit() -> g_application_quit()
> > 
> > - Unified command line option handling:
> >   The logic has moved from the main functions and split in three, the
> >   common options, and specific ones for each application. With this, the
> >   main functions were highly simplified, and now basically responsible
> >   for instantiating the App object and running the main loop.
> > 
> > - All Window objects must be associated with the Application, and with
> >   this, there is no need to emit our own 'window-added' signal, it will
> >   be done by GtkApplication by the time gtk_application_add_window() is
> >   called. The 'window-removed' signal has also been removed, as it was
> >   not being used anyway.
> 
> GApplication was added in glib 2.28, but some of the API you are using (
> g_application_add_option_group ) was added as recently as glib 2.40.
> configure.ac needs to be updated to reflect this, or some alternatives
> need to be considered if the glib 2.40 is too new (el7.0 had a too old
> glib, el7.1 is fine, fedora 21 and newer are fine too).

Yep, we need to agree which min platform we're targetting. It is nice
to see RHEL7 rebasing GTK, as that makes life easier. We should not
only consider RHEL though. It would be desirable if someone can provide
a list of GTK versions in current SLES, Ubuntu LTS, Debian and RHEL7
updates, and we can thus make sure we don't pick something that excludes
a major distro's current long term release (I'm assuming all the non-LTS
distros will be just fine since they track current state of art).

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|