[virt-tools-list] [PATCH 4/4] Port to GtkApplicationWindow API's

[Jonathon Jongsma]

On Thu, 2015-12-03 at 12:20 -0200, Eduardo Lima (Etrunko) wrote:
> On 12/01/2015 03:17 PM, Jonathon Jongsma wrote:
> > Hmm, I don't quite understand most of these changes. 
> > 
> > Why are you removing the window from the xml file instead of just changing
> > the
> > 'class' attribute to GtkApplicationWindow? (Of course, we can't set the
> > 'application' property of the window inside of the builder file, so we still
> > have to set that by continuing to call gtk_application_add_window() or
> > setting
> > the GtkWindow::application property on the retrieved window object). 
> 
> GtkBuilder will not accept GtkApplicationWindow, so I think it is
> supposed to be manually created.

I tried it here, and it seemed to work fine for me. Of course, as I mentioned
above, you still have to make sure to set the associated application property
after you retrieve it.


> 
> > 
> > Also, I don't quite understand why the code had to be moved from _init to
> > _constructed. Can you expand on that?
> > 
> 
> Sure, the problem is that in _init we still don't have the 'app' pointer
> properly set, while on _constructed it is.
> 


yep, good point.

Jonathon