[virt-tools-list] [virt-manager PATCH 2/2] Do not use vmvga on RHEL

[Cole Robinson]

On 02/24/2015 07:59 AM, Giuseppe Scrivano wrote:
> Fallback to VGA
> 
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1179652
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  virtinst/guest.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index 066c0eb..e0b59ba 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -1,7 +1,7 @@
>  #
>  # Common code for all guests
>  #
> -# Copyright 2006-2009, 2013, 2014 Red Hat, Inc.
> +# Copyright 2006-2009, 2013, 2014, 2015 Red Hat, Inc.
>  # Jeremy Katz <katzj at redhat.com>
>  #
>  # This program is free software; you can redistribute it and/or modify
> @@ -1065,6 +1065,8 @@ class Guest(XMLBuilder):
>              self._add_spice_usbredir()
>  
>          video_model = self._os_object.get_videomodel(self)
> +        if self.conn.stable_defaults() and video_model == 'vmvga':
> +            video_model == 'vga'
>          for video in self.get_devices("video"):
>              if video.model == video.MODEL_DEFAULT:
>                  video.model = video_model
> 

ACK but with a test case added that covers this. See
xmlconfig.py:testOSDeviceDefaultChange as an example. Not sure if you can just
extend that test case or if it requires a new XML file though

- Cole