[virt-tools-list] [virt-manager PATCH 1/2] Disable domain events with XEN

[Cole Robinson]

On 02/25/2015 10:34 AM, Giuseppe Scrivano wrote:
> When XEN is used, disable domain events and use polling.
> 
> On RHEL-5.9 virDomainInfo() seems to not report correctly the domain
> status when called immediately after the event is received.
> 
> Solves: https://bugzilla.redhat.com/show_bug.cgi?id=1177207
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  virtManager/connection.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/virtManager/connection.py b/virtManager/connection.py
> index a510b11..07763cc 100644
> --- a/virtManager/connection.py
> +++ b/virtManager/connection.py
> @@ -752,6 +752,10 @@ class vmmConnection(vmmGObject):
>              self.schedule_priority_tick(pollnet=True, force=True)
>  
>      def _add_conn_events(self):
> +        # Fallback to polling for XEN
> +        if self.is_xen():
> +            return
> +
>          try:
>              if _disable_libvirt_events:
>                  raise RuntimeError("_disable_libvirt_events = True")
> 

This is a big hammer. I'd rather skip this only on RHEL5 vintage xen.

Can you add a support.py check like SUPPORT_CONN_WORKING_XEN_EVENTS that
specifies an hv_version for xen 3.1.0 (basically the same as the broken ACPI
xen check), and a comment explaining why it's necessary. Then use that in
connection.py

Thanks,
Cole