[virt-tools-list] [virt-manager PATCH 1/2] Disable domain events with XEN

[Cole Robinson]

On 02/25/2015 11:37 AM, Giuseppe Scrivano wrote:
> Cole Robinson <crobinso at redhat.com> writes:
> 
>> This is a big hammer. I'd rather skip this only on RHEL5 vintage xen.
>>
>> Can you add a support.py check like SUPPORT_CONN_WORKING_XEN_EVENTS that
>> specifies an hv_version for xen 3.1.0 (basically the same as the broken ACPI
>> xen check), and a comment explaining why it's necessary. Then use that in
>> connection.py
> 
> ok to push this?
> 
> Thanks,
> Giuseppe
> 
> diff --git a/virtManager/connection.py b/virtManager/connection.py
> index a510b11..a907a3f 100644
> --- a/virtManager/connection.py
> +++ b/virtManager/connection.py
> @@ -25,6 +25,7 @@ import os
>  import socket
>  import time
>  import traceback
> +from virtinst import support
>  
>  import libvirt
>  import virtinst
> @@ -752,6 +753,9 @@ class vmmConnection(vmmGObject):
>              self.schedule_priority_tick(pollnet=True, force=True)
>  
>      def _add_conn_events(self):
> +        if not self.check_support(support.SUPPORT_CONN_WORKING_XEN_EVENTS):
> +            return
> +
>          try:
>              if _disable_libvirt_events:
>                  raise RuntimeError("_disable_libvirt_events = True")
> diff --git a/virtinst/support.py b/virtinst/support.py
> index 2a66314..0b11076 100644
> --- a/virtinst/support.py
> +++ b/virtinst/support.py
> @@ -262,6 +262,7 @@ SUPPORT_CONN_DEFAULT_QCOW2 = _make(
>  SUPPORT_CONN_DEFAULT_USB2 = _make(
>      version="0.9.7", hv_version={"qemu": "1.0.0", "test": 0})
>  SUPPORT_CONN_CAN_ACPI = _make(hv_version={"xen": "3.1.0", "all": 0})
> +SUPPORT_CONN_WORKING_XEN_EVENTS = _make(hv_version={"xen": "4.0.0", "all": 0})
>  SUPPORT_CONN_SOUND_AC97 = _make(
>      version="0.8.0", hv_version={"qemu": "0.11.0"})
>  SUPPORT_CONN_SOUND_ICH6 = _make(
> 

ACK

- Cole