[virt-tools-list] [PATCH] fix source name attribute for gluster volumes

Cole Robinson crobinso at redhat.com
Tue Jan 27 18:54:17 UTC 2015


On 01/27/2015 01:52 PM, Cole Robinson wrote:
> On 01/27/2015 08:10 AM, Anatoly.Belikov.wormblood at gmail.com wrote:
>> From: Anatoly Belikov <wormblood at gmail.com>
>>
>> ---
>>  virtinst/devicedisk.py | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
>> index ac03716..df2befc 100644
>> --- a/virtinst/devicedisk.py
>> +++ b/virtinst/devicedisk.py
>> @@ -627,7 +627,11 @@ class VirtualDisk(VirtualDevice):
>>  
>>          path = ""
>>          if poolxml.source_name:
>> -            path += poolxml.source_name + "/"
>> +            path += poolxml.source_name
>> +            if poolxml.type == poolxml.TYPE_GLUSTER:
>> +                path += poolxml.source_path
>> +            if not path.endswith('/'):
>> +                path += "/"
>>          path += volxml.name
>>          self.source_name = path
>>          self.type = "network"
>>
> 
> Thanks for the patch. Can you describe how to reproduce this issue? If via
> virt-install, please provide the full command line and debug output, since I'd
> like to add a test case that covers this
> 
> Thanks,
> Cole

Hmm, Anatoly.Belikov.wormblood at gmail.com bounced, so trying with the address
from git

- Cole




More information about the virt-tools-list mailing list