[virt-tools-list] [virt-viewer] ovirt: Fail gracefully when hostname is missing

Christophe Fergeau cfergeau at redhat.com
Fri Jan 30 07:27:59 UTC 2015


When parsing info returned by oVirt REST API, the hostname should be
present. However, I recently run remote-viewer against a buggy oVirt
instance where the hostname was missing. This commit handles better this
situation by displaying an error message and exiting.
---
 src/remote-viewer.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 34f01da..59250ef 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -915,6 +915,13 @@ create_ovirt_session(VirtViewerApp *app, const char *uri, GError **err)
     gport = g_strdup_printf("%d", port);
     gtlsport = g_strdup_printf("%d", secure_port);
 
+    if (ghost == NULL) {
+        g_set_error(&error, VIRT_VIEWER_ERROR, VIRT_VIEWER_ERROR_FAILED,
+                    _("oVirt VM %s has no host information"), vm_name);
+        g_debug("%s", error->message);
+        goto error;
+    }
+
     if (type == OVIRT_VM_DISPLAY_SPICE) {
         session_type = "spice";
     } else if (type == OVIRT_VM_DISPLAY_VNC) {
-- 
2.1.0




More information about the virt-tools-list mailing list