[virt-tools-list] [virt-manager PATCH] virt-xml: refactor the handling of --define and --update

Pavel Hrdina phrdina at redhat.com
Thu Jul 2 12:05:02 UTC 2015


On Wed, Jul 01, 2015 at 08:04:40PM -0400, Cole Robinson wrote:
> On 07/01/2015 06:42 AM, Pavel Hrdina wrote:
> > The code was wrong in many ways.  The main issue was, that for live
> > updates we were using config XML instead of live XML.
> > 
> > This patch fixes the --update and --define options to work properly as
> > described in man page.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1192875
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---

[...]

> 
> Breaks the test suite for me
> 
> - Cole

Right, I forget to run the test suite.  I'll send a v2 with fix for that case.

Pavel




More information about the virt-tools-list mailing list