[virt-tools-list] [virt-viewer][PATCH] virt-viewer: set keepAlive on libvirt connection

[Jonathon Jongsma]

On Wed, 2015-07-01 at 16:44 +0200, Pavel Grunt wrote:
> On Tue, 2015-06-30 at 07:56 -0400, Fabiano Fidencio wrote:
> > 
> > ----- Original Message -----
> > > From: "Pavel Hrdina" <phrdina at redhat.com>
> > > To: "Fabiano Fidêncio" <fidencio at redhat.com>
> > > Cc: virt-tools-list at redhat.com
> > > Sent: Tuesday, June 30, 2015 11:22:19 AM
> > > Subject: Re: [virt-tools-list] [virt-viewer][PATCH] virt-viewer: set 
> > > keepAlive on libvirt connection
> > > 
> > > Hi Fabiano,
> > > 
> > > The propose of this diff was to show, that this will resolve that bug.  I
> > > could
> > > have send it by myself, but the reason was to let it to virt-viewer
> > > developers
> > > to also introduce the possibility to specify the last two arguments of
> > > 'virConnectSetKeepAlive' as user may want to use different one.  So instead
> > > of
> > > hard-coding some time interval use default values only in case, that user
> > > won't
> > > tell otherwise.
> > > 
> > 
> > As said in https://bugzilla.redhat.com/show_bug.cgi?id=1164052#c9, exposing 
> > the keepalive, internval and count to the users is not something that we 
> > (Christophe and myself, at least) want to do.
> > 
> Ack, I also agree that we don't need to expose it.
> 
> Pavel


Agreed. We should just pick some decent values and use that. I don't
think it needs to be configurable. 

Jonathon