[virt-tools-list] [virt-manager PATCH] virtinst.cpu: fix copy host cpu definition

Cole Robinson crobinso at redhat.com
Tue Jul 14 15:53:16 UTC 2015


On 07/14/2015 09:53 AM, Pavel Hrdina wrote:
> Commit cac4ac14 updated cpu features to use XMLBuilder and this change
> removes the 'Features' class.  There is no longer any '.names()'
> method to return names, so just cycle through all features and use a
> name attribute instead.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1240938
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  virtinst/cpu.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/virtinst/cpu.py b/virtinst/cpu.py
> index b12fd30..fb17bb7 100644
> --- a/virtinst/cpu.py
> +++ b/virtinst/cpu.py
> @@ -104,8 +104,8 @@ class CPU(XMLBuilder):
>  
>          for feature in self.features:
>              self.remove_feature(feature)
> -        for name in cpu.features.names():
> -            self.add_feature(name)
> +        for feature in cpu.features:
> +            self.add_feature(feature.name)
>  
>      def vcpus_from_topology(self):
>          """
> 

Thanks, applied. (also added a separate commit with a test case that would
have caught this)

- Cole




More information about the virt-tools-list mailing list