[virt-tools-list] [virt-viewer][PATCH] Revert "virt-viewer: set keepAlive on libvirt connection"

Fabiano Fidêncio fidencio at redhat.com
Thu Jul 16 12:04:33 UTC 2015


This reverts commit 08378ec4dc3623792c64a3bae6279eac1c3c153e.

The commit in question was done in order to fix rhbz#1164052, but has
been proven that it's not necessary depending on the libvirt version on
the remote host.
Considering we don't want to keep a workaround that can, actually, hide
a proper bug that must be fixed (or in virt-viewer, or elsewhere),
reverting this patch seems the safest option for now.
---
 src/virt-viewer.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 9b4391e..3a8ba4e 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -965,10 +965,6 @@ virt_viewer_connect(VirtViewerApp *app, GError **err)
         g_debug("Unable to register close callback on libvirt connection");
     }
 
-    if (virConnectSetKeepAlive(priv->conn, 5, 3) < 0) {
-        g_debug("Unable to set keep alive");
-    }
-
     return 0;
 }
 
-- 
2.4.4




More information about the virt-tools-list mailing list