[virt-tools-list] [virt-viewer 1/2] build-sys: Always prepend '-' to buildid
Daniel P. Berrange
berrange at redhat.com
Tue Jun 2 14:23:53 UTC 2015
On Tue, Jun 02, 2015 at 04:18:58PM +0200, Christophe Fergeau wrote:
> This was added in commit 3232ddb and mistakenly removed in 28a6bd6
> Without this added dash, remote-viewer --version gives something like
> "3.01" with a '1' buildid.
No, that was not a mistake. We do /not/ want a '-' in the buildid
value, because we use that value to create WINDOWS_PRODUCTVERSION
variable which should not include '-'.
I think you should change the remote-viewer remote_viewer_version()
method to print the '-'
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the virt-tools-list
mailing list