[virt-tools-list] [RFC virt-viewer 10/12] spec: Take Epoch into account in package buildid

[Jonathon Jongsma]

On Tue, 2015-06-02 at 16:29 +0200, Christophe Fergeau wrote:
> ---
>  virt-viewer.spec.in | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/virt-viewer.spec.in b/virt-viewer.spec.in
> index dfc819c..b75ac45 100644
> --- a/virt-viewer.spec.in
> +++ b/virt-viewer.spec.in
> @@ -104,7 +104,13 @@ autoreconf -if
>  %define govirt_arg --with-ovirt
>  %endif
>  
> -%configure %{spice_arg} %{gtk_arg} %{govirt_arg} --with-buildid=%{release} --disable-update-mimedb
> +%if 0%{epoch}
> +%define buildid %{epoch}:%{release}
> +%else
> +%define buildid %{release}
> +%endif
> +
> +%configure %{spice_arg} %{gtk_arg} %{govirt_arg} --with-buildid=%{buildid} --disable-update-mimedb
>  %__make %{?_smp_mflags}
>  
> 


It doesn't seem that virt_viewer_compare_buildid() currently handles the
epoch? It'd be good to add a test case for that.