[virt-tools-list] [virt-manager PATCH 1/2] clitest: remove virt-xml test --console target_type=serial"

[Chen, Hanxiao]

> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Saturday, June 06, 2015 6:09 AM
> To: Chen, Hanxiao/陈 晗霄; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH 1/2] clitest: remove virt-xml
> test --console target_type=serial"
> 
> On 06/04/2015 11:14 PM, Chen Hanxiao wrote:
> > libvirt commit:
> > 8728a78e904de7ddfa32b7761b40d6339fa15030
> > Always add 'console' matching the 'serial' device
> >
> > We don't need this test since then.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> > ---
> >  tests/clitest.py | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/clitest.py b/tests/clitest.py
> > index 056ec4a..9e7026a 100644
> > --- a/tests/clitest.py
> > +++ b/tests/clitest.py
> > @@ -816,7 +816,6 @@ c.add_compare("--memballoon model=none",
> "edit-simple-memballoon")
> >  c.add_compare("--serial pty", "edit-simple-serial")
> >  c.add_compare("--parallel unix,path=/some/other/log", "edit-simple-parallel")
> >  c.add_compare("--channel null", "edit-simple-channel")
> > -c.add_compare("--console target_type=serial", "edit-simple-console")
> >  c.add_compare("--filesystem /1/2/3,/4/5/6,mode=mapped",
> "edit-simple-filesystem")
> >  c.add_compare("--video cirrus", "edit-simple-video",
> compare_check=support.SUPPORT_CONN_VIDEO_NEW_RAM_OUTPUT)
> >  c.add_compare("--sound pcspk", "edit-simple-soundhw")
> >
> 
> Did that libvirt commit break our test suite? If so, we should just change the
> test options so it _doesn't_ break. The idea of that test case is to make sure
> virt-xml --console works. So maybe adjust it to edit --console name=$foo or
> something
> 
Yes, it breaks our test suite.
With that libvirt commit, serial console will be added automatically.

I'll update the test cases with another tartget_type.

Regards,
- Chen