[virt-tools-list] [PATCH virt-viewer v2 0/7] Authentication failure changes

Jonathon Jongsma jjongsma at redhat.com
Fri Jun 19 19:41:47 UTC 2015


Thanks Pavel,

Pushed with those minor changes you mentioned.

Jonathon


On Fri, 2015-06-19 at 09:34 +0200, Pavel Grunt wrote:
> Hi Jonathon,
> 
> Thank you for the series. Ack with changes I mentioned in the patch #7 (commit
> message), and in the patch #3 (affecting #6). 
> 
> Pavel
> 
> On Thu, 2015-06-18 at 15:15 -0500, Jonathon Jongsma wrote:
> > Here's a new patchset that includes the fix that I previously posted for
> > cancelling an authentication dialog when virt-viewer is run with --reconnect.
> > That patch didn't handle the case of VNC guests. This series fixes the same
> > issue for VNC guests, and in the process introduces a bit of refactoring to
> > make handling of authentication issues more similar between spice and vnc
> > sessions.
> > 
> > The original patches (#1 and #7) are unchanged, but there are five additional
> > patches between them.
> > 
> > Jonathon Jongsma (7):
> >   Move SpiceSession setup to create_spice_session()
> >   Session: add vfunc to check auth retry capability
> >   Fix inconsistencies in session auth failures
> >   Rename session-auth-failed to session-auth-unsupported
> >   VNC session: emit session-cancelled signal
> >   Automatically retry auth failures for VNC
> >   Don't wait for reconnect when user cancels auth
> > 
> >  src/virt-viewer-app.c           |  42 ++++++-------
> >  src/virt-viewer-app.h           |   1 +
> >  src/virt-viewer-session-spice.c | 127 +++++++++++++++++++++------------------
> > -
> >  src/virt-viewer-session-vnc.c   |   3 +-
> >  src/virt-viewer-session.c       |  15 ++++-
> >  src/virt-viewer-session.h       |   4 +-
> >  src/virt-viewer.c               |   2 +-
> >  7 files changed, 105 insertions(+), 89 deletions(-)
> > 





More information about the virt-tools-list mailing list