[virt-tools-list] [PATCH] Add G_SOURCE_REMOVE to vir-glib-compat

Fabiano Fidêncio fabiano at fidencio.org
Wed Mar 11 10:51:00 UTC 2015


On Wed, Mar 11, 2015 at 11:23 AM, Christophe Fergeau
<cfergeau at redhat.com> wrote:
> On Wed, Mar 11, 2015 at 11:14:33AM +0100, Fabiano Fidêncio wrote:
>> G_SOURCE_REMOVE was introduced in GLib 2.32 and has its value defined as
>> FALSE.
>> ---
>>  src/virt-glib-compat.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/src/virt-glib-compat.h b/src/virt-glib-compat.h
>> index 37b6f61..4103621 100644
>> --- a/src/virt-glib-compat.h
>> +++ b/src/virt-glib-compat.h
>> @@ -71,6 +71,10 @@ G_BEGIN_DECLS
>>  GByteArray *g_byte_array_new_take (guint8 *data, gsize len);
>>  #endif
>>
>> +#if !GLIB_CHECK_VERSION(2,32,0)
>> +#define G_SOURCE_REMOVE FALSE;
>> +#endif
>
> Maybe add G_SOURCE_CONTINUE at the same time for completeness?
>
> ACK either way.
>
> Christophe
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Sure, I'll do it before push the patch.

-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list