[virt-tools-list] [virt-viewer 2/3] ovirt: Don't try to use invalid port numbers

Christophe Fergeau cfergeau at redhat.com
Thu Mar 12 16:54:07 UTC 2015


If a remote oVirt VM don't specify a port/secure port number, we'd still
try to pass it down to spice-gtk, which would then complain that 0 (the
default value) isn't a valid port number.
This commit make sure we filter out the default port/secure-port value
and pass NULL to spice-gtk instead when we get these values.
---
 src/remote-viewer.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/remote-viewer.c b/src/remote-viewer.c
index 12bd912..4541515 100644
--- a/src/remote-viewer.c
+++ b/src/remote-viewer.c
@@ -916,8 +916,12 @@ create_ovirt_session(VirtViewerApp *app, const char *uri, GError **err)
                  "host-subject", &host_subject,
                  "proxy-url", &proxy_url,
                  NULL);
-    gport = g_strdup_printf("%d", port);
-    gtlsport = g_strdup_printf("%d", secure_port);
+    if (port != 0) {
+        gport = g_strdup_printf("%d", port);
+    }
+    if (secure_port != 0) {
+        gtlsport = g_strdup_printf("%d", secure_port);
+    }
 
     if (ghost == NULL) {
         g_set_error(&error, VIRT_VIEWER_ERROR, VIRT_VIEWER_ERROR_FAILED,
-- 
2.1.0




More information about the virt-tools-list mailing list