[virt-tools-list] [PATCH virt-viewer] virt-viewer: Inform when connecting to nonexistent guest

[Fabiano Fidêncio]

On Fri, Mar 13, 2015 at 11:44 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> Since commit 88f634179e56742a21fb4c7efc270e4203322d74 using virt-viewer
> without a guest name or with a wrong name is not treated as the error.
> That commit also removed a debug log saying that a guest cannot be found.

Hmm. The commit message is inaccurate. It is treated as an error.
There is an error dialog popping out. It is just not shown as part of
the debug messages.

>
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1201177

I'd use "Resolves" instead of fixes.

> ---
>  src/virt-viewer.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/virt-viewer.c b/src/virt-viewer.c
> index acad6c6..4919a06 100644
> --- a/src/virt-viewer.c
> +++ b/src/virt-viewer.c
> @@ -726,6 +726,8 @@ virt_viewer_initial_connect(VirtViewerApp *app, GError **error)
>              goto wait;
>          } else {
>              VirtViewerWindow *main_window = virt_viewer_app_get_main_window(app);
> +            if (priv->domkey != NULL)
> +                g_debug("Cannot find guest %s", priv->domkey);
>              dom = choose_vm(virt_viewer_window_get_window(main_window),
>                              &priv->domkey,
>                              priv->conn,
> --
> 2.3.2
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

ACK with the changes in the commit log.

Best Regards,
-- 
Fabiano Fidêncio