[virt-tools-list] [PATCH] virt-manager: Don't clear all page visibilities during initialization

[Cole Robinson]

On 03/13/2015 09:31 AM, Marc Deslauriers wrote:
> Hello,
> 
> Here is a patch to correct grab issues when windows overlap stemming from
> incorrect page visibilities.
> 
> Thanks,
> 
> Marc.
> 
>>From a11986b10f13bc85f0be578e5460369a1ecafb57 Mon Sep 17 00:00:00 2001
> From: Marc Deslauriers <marc.deslauriers at ubuntu.com>
> Date: Fri, 13 Mar 2015 09:28:02 -0400
> Subject: [PATCH] Don't clear all page visibilities during initialization
> 
> Since commit dfa23765, page_changed() sets page visibilities based on the
> value of the newpage parameter. Calling the function without it being set
> makes all pages invisible at once during initialization, resulting in a
> weird scenario which prevents the window from getting proper focus events
> when another window partially overlaps it, resulting in stuck grabs.

Can we instead take the bit added in dfa23765 and stick it under:

if newpage is not None:
    <code>

page_changed has other initial init bits (like setting fullscreen state) and
could grow more in the future.

Thanks,
Cole

> ---
>  virtManager/console.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/virtManager/console.py b/virtManager/console.py
> index 545a82a..2ff751a 100644
> --- a/virtManager/console.py
> +++ b/virtManager/console.py
> @@ -646,8 +646,6 @@ class vmmConsolePages(vmmGObjectUI):
>              self.config.on_keyboard_grab_default_changed(
>              self.keyboard_grab_default_changed))
> 
> -        self.page_changed()
> -
> 
>      def is_visible(self):
>          if self.topwin:
>