[virt-tools-list] [PATCH virt-viewer v2 1/3] virt-viewer: Clean up if no vm was chosen

Pavel Grunt pgrunt at redhat.com
Tue Mar 17 14:42:29 UTC 2015


It is safe to clean up when running virt-viewer without specifying
vm name if no vm was chosen. It brings back behavior before 88f6341.

The 'if (dom == NULL && err != NULL)' part was affected by commits
824c4b9, 1eaaf8c, 15c7d17 so the check for 'err' is not needed anymore.
---
https://www.redhat.com/archives/virt-tools-list/2015-March/msg00103.html
I decided to do this change before sending patches for user cancel
---
 src/virt-viewer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index acad6c6..3a55057 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -730,7 +730,7 @@ virt_viewer_initial_connect(VirtViewerApp *app, GError **error)
                             &priv->domkey,
                             priv->conn,
                             &err);
-            if (dom == NULL && err != NULL) {
+            if (dom == NULL) {
                 goto cleanup;
             }
         }
-- 
2.3.2




More information about the virt-tools-list mailing list