[virt-tools-list] [PATCH virt-viewer v2 2/3] Exit normally when canceling dialog

[Pavel Grunt]

> 
> I guess I was not very clear. My point was that since user_cancelled
> avoids calling gtk_main() at all, anything thing that sets
> user_cancelled after the mainloop is already running is pointless
> because we never check the value of user_cancelled after that.
> 
> Initially I thought that authenticate_db() was only triggered as part
> of
> an asynchronous network communication (i.e. while the mainloop was
> running). But now I see that it can happen synchronously before the
> mainloop runs. But I think my other comments (regarding
> virt_viewer_session_spice_main_channel_event(), etc.) are still
> accurate. These callbacks only happen while the mainloop is
> iterating,
> so setting user_cancelled there should have no effect on the behavior
> of
> the application.
> 
> Jonathon
> 
Ok, thanks for clarification... you are right about the session authentication, it doesn't make sense to have it there.

VIRT_VIEWER_ERROR_CANCELLED makes sense only for libvirt / ovirt authentication and 'vm choose' dialog.

Thanks,

Pavel